[Webkit-unassigned] [Bug 108007] Stop defining PLATFORM(MAC) when building for PLATFORM(IOS) and PLATFORM(IOS_SIMULATOR)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108007





--- Comment #1 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>  2013-01-26 11:16:44 PST ---
Looking at making a patch for this, I wonder if this would be a better change:

- Stop defining PLATFORM(MAC) when building for PLATFORM(IOS) and PLATFORM(IOS_SIMULATOR).
- Rename OS(DARWIN) to OS(APPLE).
- Replace "PLATFORM(MAC) || PLATFORM(IOS)" with OS(APPLE) (unless a better ENABLE() or USE() macro applies).

I know OS(DARWIN) is supped to represent the kernel or low-level parts of the operating system, but I think it works both to represent the kernel as well as the UI-level parts of the operating system.  And it's defined when __APPLE__ is defined.

I was originally going to add a PLATFORM(APPLE) macro along side OS(DARWIN), but it didn't seem to make sense to use "OS(DARWIN)" when "OS(APPLE)" is more generally useful.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.