[Webkit-unassigned] [Bug 107364] Improve PageVisibility API with enums

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 26 09:56:08 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=107364





--- Comment #8 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>  2013-01-26 09:58:03 PST ---
(From update of attachment 184635)
View in context: https://bugs.webkit.org/attachment.cgi?id=184635&action=review

No COMPILE_ASSERT() statements?

> Source/WebKit/mac/WebView/WebView.mm:412
> +static PageVisibilityState corePageVisibilityState(WebPageVisibilityState visibilityState)

I think it would be best to name this "core(WebPageVisibilityState visibilityState)" since C++ will disambiguate based on the argument type.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list