[Webkit-unassigned] [Bug 108004] [chromium] WebConsoleMessage is missing LevelDebug (chromium bug 172416)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108004





--- Comment #5 from Kevin Day <kevinday at gmail.com>  2013-01-26 00:44:01 PST ---
(In reply to comment #3)
> (From update of attachment 184858 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=184858&action=review
> 
> > Source/WebKit/chromium/public/WebConsoleMessage.h:44
> > -        LevelError
> > +        LevelError,
> > +        LevelDebug
> 
> Do we have entries in AssertMachingEnums for these?

Source/WebKit/chromium/src/AssertMatchingEnums.cpp makes no mention of message levels, or anything to do with the console.

It's also probably safe to add to this enum without ensuring it matches, since out-of-bounds enum values are already getting passed into the console renderer every time console.debug is being called. Without debug assertions it's getting silently converted to logging::LOG_VERBOSE, so this ends up being a no-op and just documenting better what's actually happening.

I'm happy to add a test if you guys want though?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.