[Webkit-unassigned] [Bug 106815] [Chromium] Tests and fixes for spell checker behavior

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=106815





--- Comment #22 from Rouslan Solomakhin <rouslan+webkit at chromium.org>  2013-01-25 15:55:09 PST ---
(In reply to comment #20)
> I think you need to update the symbol exports for the platforms that are failing:
> http://trac.webkit.org/wiki/ExportingSymbols

Thank you for pointing that out. I am testing the patch with exported symbols now.

> The tests are still failing on the cr-linux box.  What platform are you running the tests on?

I have been running the following command in Chromium.

$ ~/src/webkit/tools/layout_tests/run_webkit_tests.sh --no-pixel-tests platform/chromium/editing/spelling

Although this is a Chromium tool, my WebKit in src/third_party/WebKit is checked out directly from git://git.webkit.org/WebKit.git.

> There's a lot of common boilerplate in the tests.  You might want to factor that into a shared .js file that the tests all include.  You would put the shared .js file in a resources subdirectory.

Will do.

> I thought Safari (and OS X in general) always selected the word under the cursor when you right click?

I double-checked and you are correct. Chrome matches Safari in that misspelled words are selected when you right click. Safari also selects correctly spelled words when you right click. Chrome does not, however.

> We normally only put tests in a platform specific subdirectory when we're testing platform specific behavior (e.g., there are some Apple Script tests in platform/mac).  None of these behaviors seem platform specific to me, although there might be slightly different results on different platforms, in which case, we can check in multiple results files or disable the failing tests on the platforms they fail on.

Sounds good. I am working on it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.