[Webkit-unassigned] [Bug 106842] adding support for DiscardablePixelRef for caching lazily decoded images

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=106842





--- Comment #65 from Min Qin <qinmin at chromium.org>  2013-01-25 15:52:35 PST ---
(From update of attachment 184817)
View in context: https://bugs.webkit.org/attachment.cgi?id=184817&action=review

>> Source/WebCore/platform/graphics/chromium/ImageDecodingStore.cpp:245
>> +            if (!cacheEntry->useCount() && (!cacheEntry->isDiscardable() || !m_cacheLimitInBytes))
> 
> I don't understand the condition for !m_cacheLimitInBytes. When will it be zero? It seems to be not necessary.

in the dtor we set it to 0. So in that case, we should just clean up everything.

>> Source/WebCore/platform/graphics/chromium/ImageDecodingStore.cpp:251
>> +        removeFromCacheListInternal(heapCacheEntriesToDelete);
> 
> I think this line is wrong.

fixed, no need to split between heap and discardable now

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.