[Webkit-unassigned] [Bug 107931] [EFL][WK2] Introduce a WebView class as counterpart for WKViewRef

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107931





--- Comment #8 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2013-01-25 09:10:11 PST ---

> > Source/WebKit2/UIProcess/API/efl/EwkView.cpp:131
> > +    m_webPageProxy->close();
> 
> So we don't free m_evasObject here?

I tried :-) but gave up for now, we end up double freeing

> > Source/WebKit2/UIProcess/API/efl/EwkView.h:106
> > +class WebView {
> 
> Shouldn't this be RefCounted?

Could be, but maybe it should be an APIObject instead as it is supposed to be used with the C API.

> > Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp:78
> > +    evas_object_del(WKViewGetEvasObject(m_view));
> 
> Shouldn't we WKRelease(m_view)? If the WebView destructor frees the evasObject and if it is RefCounted, it should work, right?

That won't work yet, as said above, I tried and gave up. If you want to give it a try, feel free, but it can also be done later.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.