[Webkit-unassigned] [Bug 107931] [EFL][WK2] Introduce a WebView class as counterpart for WKViewRef

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107931





--- Comment #7 from Christophe Dumez <christophe.dumez at intel.com>  2013-01-25 09:05:05 PST ---
(From update of attachment 184760)
View in context: https://bugs.webkit.org/attachment.cgi?id=184760&action=review

> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:131
> +    m_webPageProxy->close();

So we don't free m_evasObject here?

> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:922
> +    WKRetainPtr<WKURLRef> wkActiveURL = WKPageCopyActiveURL(wkPage());

Needs to be adopted.

> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:923
> +    WKRetainPtr<WKStringRef> wkURLString = WKURLCopyString(wkActiveURL.get());

Ditto.

> Source/WebKit2/UIProcess/API/efl/EwkView.h:106
> +class WebView {

Shouldn't this be RefCounted?

> Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp:78
> +    evas_object_del(WKViewGetEvasObject(m_view));

Shouldn't we WKRelease(m_view)? If the WebView destructor frees the evasObject and if it is RefCounted, it should work, right?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.