[Webkit-unassigned] [Bug 107829] Web Inspector: support JavaScript variable mutation in protocol and V8 bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107829


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #184524|review?                     |review+
               Flag|                            |




--- Comment #9 from Pavel Feldman <pfeldman at chromium.org>  2013-01-24 22:51:27 PST ---
(From update of attachment 184524)
View in context: https://bugs.webkit.org/attachment.cgi?id=184524&action=review

> Source/WebCore/bindings/v8/DebuggerScript.js:99
> +    if (!mirror.isFunction()) {

nit: no need for {}

> Source/WebCore/bindings/v8/DebuggerScript.js:108
> +    if (!scopeMirror) {

ditto

> Source/WebCore/inspector/InjectedScriptSource.js:434
> +                    return String(e);

return e.toString()

> Source/WebCore/inspector/InjectedScriptSource.js:624
> +            return String(e);

ditto

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.