[Webkit-unassigned] [Bug 107829] Web Inspector: support JavaScript variable mutation in protocol and V8 bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107829





--- Comment #7 from Peter Rybin <prybin at chromium.org>  2013-01-24 10:35:31 PST ---
> > Source/WebCore/inspector/InjectedScript.cpp:119
> > +void InjectedScript::setVariableValue(ErrorString* errorString, const ScriptValue& callFrames, const String* callFrameOpt, const String* functionObjectIdOpt, int scopeNumber, const String& variableName, const String& newValueStr)
> callFrameOpt -> callFrameIdOpt

Done

> > Source/WebCore/inspector/InjectedScriptSource.js:585
> > +     * @param {*} newValue, unmasked custom value.
> @param {RuntimeAgent.CallArgument} newValue? or is it just a {string} here?

Yes, that's a bug. Thank you for noting this.
Done

> > Source/WebCore/inspector/InjectedScriptSource.js:586
> > +     * @return {*}
> @return {string|undefined}

Done

> > Source/WebCore/inspector/Inspector.json:2845
> > +                    { "name": "callFrame", "$ref": "CallFrameId", "optional": true, "description": "Id of callframe that holds variable" },
> name it "callFrameId"?

Done

> > Source/WebCore/inspector/Inspector.json:2849
> > +                    { "name": "newValue", "$ref": "Runtime.CallArgument", "description": "New variable value" }
> dots at the end of descriptions are missing

Done

> > Source/WebCore/inspector/InspectorDebuggerAgent.cpp:587
> > +        injectedScript = m_injectedScriptManager->injectedScriptForObjectId(*callFrame);
> callFrame -> callFrameId

Done

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.