[Webkit-unassigned] [Bug 96272] NPN_InitializeVariantWithStringCopy is wrong for platforms that return NULL from malloc(0)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96272


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #184453|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #19 from Darin Adler <darin at apple.com>  2013-01-24 09:31:05 PST ---
(From update of attachment 184453)
View in context: https://bugs.webkit.org/attachment.cgi?id=184453&action=review

> Source/WebCore/ChangeLog:10
> +        No new tests. This is platform dependant.

Spelling error: dependent is not spelled with an "a"

> Source/WebCore/bridge/npruntime.cpp:90
> +        // switching to fastMalloc would be better to avoid length check but this is not desirable
> +        // as NPN_MemAlloc is using malloc and there might be plugins that mix NPN_MemAlloc and malloc too

WebKit comment coding style is “sentence style”. First letter capitalized, period at end of sentence.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.