[Webkit-unassigned] [Bug 107813] Web Inspector: Filters on Console panel

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107813





--- Comment #5 from Andrey Adaikin <aandrey at chromium.org>  2013-01-24 07:29:28 PST ---
(From update of attachment 184473)
View in context: https://bugs.webkit.org/attachment.cgi?id=184473&action=review

> Source/WebCore/inspector/front-end/ConsoleView.js:497
> +        if (idx == -1)

we try to use "===" everywhere, here and below

> Source/WebCore/inspector/front-end/ConsoleView.js:505
> +    _shouldBeVisible: function(msg) {

@return missing

> Source/WebCore/inspector/front-end/ConsoleView.js:523
> +                    messageElement.parentElement.removeChild(messageElement);

messageElement.removeSelf()

> Source/WebCore/inspector/front-end/ConsoleView.js:794
> +            if (node) {

just this.messagesElement.insertBefore(element, node); - it's cleaner :)

insertBefore already behaves like appendChild if node is null

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.