[Webkit-unassigned] [Bug 106842] adding support for DiscardablePixelRef for caching lazily decoded images

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=106842





--- Comment #40 from James Robinson <jamesr at chromium.org>  2013-01-23 17:52:34 PST ---
(From update of attachment 184272)
View in context: https://bugs.webkit.org/attachment.cgi?id=184272&action=review

> Source/WebCore/platform/graphics/chromium/DiscardablePixelRef.cpp:55
> +    delete pixelRef;

instead of manually calling delete, can you put pixelRef in an OwnPtr<> and .leakPtr() it on line 49?

> Source/WebCore/platform/graphics/chromium/DiscardablePixelRef.cpp:89
> +        m_discardable->lock();

don't you need to check the return value of lock() to see if the memory's still there before calling ->data() ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.