[Webkit-unassigned] [Bug 96272] NPN_InitializeVariantWithStringCopy is wrong for platforms that return NULL from malloc(0)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96272





--- Comment #16 from Julien Brianceau <jbrianceau at nds.com>  2013-01-23 15:09:30 PST ---
(In reply to comment #15)
> Julien, can you please elaborate on your comment 10? I think that this is what preventing us from using fastMalloc to solve this siiue.

I didn't find an implementation of NPN_InitializeVariantWithString in current versions of WebKit, so my comment #10 is useless.

However there is still "STRINGZ_TO_NPVARIANT" macro (in Source/WebCore/plugins/npruntime.h), and I read this: http://stackoverflow.com/questions/1431409/firefox-npapi-plugin-development-firefox-freeze-when-calling-a-method
So I thought that we could perhaps switch to NPN_MemAlloc/NPN_MemFree calls, then switch these 2 functions' implementation to fastMalloc/fastFree (in Source/WebCore/plugins/npapi.cpp).

But it seems that there's quite an history for this: https://bugs.webkit.org/show_bug.cgi?id=20566, and I still can see this kind of comment (FIXME: This should really call NPN_MemAlloc but that's in WebKit) in Source/WebCore/bridge/NP_jsobject.cpp

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.