[Webkit-unassigned] [Bug 106842] adding support for DiscardablePixelRef for caching lazily decoded images

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 23 11:44:50 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=106842





--- Comment #38 from Min Qin <qinmin at chromium.org>  2013-01-23 11:46:42 PST ---
(From update of attachment 184061)
View in context: https://bugs.webkit.org/attachment.cgi?id=184061&action=review

Uploading a new patch to include recent changes to WebDiscardableMemory and the fix for race conditions. PTAL

>> Source/WebCore/platform/graphics/chromium/DiscardablePixelRef.cpp:42
>> +    // unlockPixels() will be called when the image decoder goes away.
> 
> Does it mean that lock to DiscardablePixelRef is held for the entire lifetime of ImageDecoder?

Yes. In ImageDecodingStore::insertAndLockCache(), when the decoder is going away, the SkBitmap associated with the imageDecoder will also gone. That's when the unlockPixels() gets called.
Since ImageFrameGenerator::decode() assigned that SkBitmap to another Skbitmap(fullSizeBitmap), so the fullSizeBitmap will have its own count on lock/unlockpixels().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list