[Webkit-unassigned] [Bug 107611] Fix rubber-band effect on non-scrollable pages
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 23 11:10:22 PST 2013
https://bugs.webkit.org/show_bug.cgi?id=107611
--- Comment #6 from Christopher Cameron <ccameron at chromium.org> 2013-01-23 11:12:15 PST ---
(In reply to comment #3)
> (From update of attachment 184098 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=184098&action=review
>
> > Source/WebCore/page/FrameView.cpp:-3777
> > - if (!isScrollable())
>
> can not isScrollable get relaxed instead? so it could take overscroll/rubber-band into account.
Maybe it would be best to add this comment to the original site of the removed isScrollable. I've updated the patch to say explicitly that
// Note that even non-scrollable views should handle wheel events, to allow for rubber-band
// over-scroll behavior
This way, it avoids hanging the other call to isScrollable in updateScrollableAreaSet. Does this look good to you?
(In reply to comment #4)
> don't mark a patch [chromium] if it touches cross-platform code
Sorry, fixed.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list