[Webkit-unassigned] [Bug 106908] [GTK] Click on an anchor link makes page title dissappear

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=106908





--- Comment #9 from Manuel Rego Casasnovas <rego at igalia.com>  2013-01-23 09:03:38 PST ---
(In reply to comment #8)
> (From update of attachment 184239 [details])
> Okay. Looks good. Did you run the unit tests?

Yes, they gave me the same results than without my patch.

>In the future you probably want to avoid the usage of booleans [1], but for this change it's probably okay.

I agree that it's better to use enums, I've read the coding style guidelines but I didn't remember all of them yet :-) Anyway in this case, for a private method I think it's not so important as when you have a public method that could be called from somewhere else.

I can include a new enum if you prefer. Let me know.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.