[Webkit-unassigned] [Bug 106908] [GTK] Click on an anchor link makes page title dissappear

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=106908


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #184239|review?                     |review+
               Flag|                            |




--- Comment #8 from Martin Robinson <mrobinson at webkit.org>  2013-01-23 08:30:57 PST ---
(From update of attachment 184239)
Okay. Looks good. Did you run the unit tests? In the future you probably want to avoid the usage of booleans [1], but for this change it's probably okay.

1. See the WebKit style guide where it says: "Prefer enums to bools on function parameters if callers are likely to be passing constants, since named constants are easier to read at the call site. An exception to this rule is a setter function, where the name of the function already makes clear what the boolean is."

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.