[Webkit-unassigned] [Bug 107648] Web Inspector: allow user to resize inspector window by dragging the toolbar

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107648


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #184189|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #3 from Pavel Feldman <pfeldman at chromium.org>  2013-01-23 04:15:57 PST ---
(From update of attachment 184189)
View in context: https://bugs.webkit.org/attachment.cgi?id=184189&action=review

A couple of nits and it is good to land.

> Source/WebCore/inspector/front-end/DockController.js:97
> +    isDockedToBottom: function() {

{ should be on the next line

> Source/WebCore/inspector/front-end/DockController.js:-125
> -            WebInspector.toolbar.setDockedToBottom(this._dockSide === WebInspector.DockController.State.DockedToBottom);

I like reversing this dependency.

> Source/WebCore/inspector/front-end/Toolbar.js:124
> +        this.element.lastHeight = window.innerHeight;

Why storing this property on element? Store it on this with private field.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.