[Webkit-unassigned] [Bug 106553] [V8] Add IDL Enum support WIP

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=106553


Nils Barth <nbarth at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #183905|0                           |1
        is obsolete|                            |




--- Comment #7 from Nils Barth <nbarth at google.com>  2013-01-23 01:44:09 PST ---
Created an attachment (id=184180)
 --> (https://bugs.webkit.org/attachment.cgi?id=184180&action=review)
address concerns (rewrite parser changes, rewrite layout test), add bindings test

Updated to address concerns - thanks for the comments, they've made the code much clearer and simpler!
Parser changes (IDLParser.pm) now much simpler b/c no domDefinition wrapper.
Layout test also much clearer and shorter due to using library.

A few questions about FIXMEs (marking where current code is incomplete):

Still have "FIXME" at a few places in the parser;
this is exactly where the parser discards data (finishes parsing a definition and then has an empty return),
so this marks where we'll need to work in future.

Also put notes in IDL and layout test b/c WebCore doesn't yet support "json" as a responseType value,
referencing the blocking bug.

Also put note in bindings test IDL that we're not testing operations yet.
(I looked around, and there are test cases out there -- interfaces using Web IDL with operations using enums -- but until we start converting these over, no practical test case.)

My question is: Is this is the correct place for these?
Should I have notes in the code? Raise a bug here on Bugzilla? Put it in personal "to do later" list?
Some/all of the above?

Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.