[Webkit-unassigned] [Bug 74358] prepare-Changelog should support updating the list of changed files
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 22 22:54:35 PST 2013
https://bugs.webkit.org/show_bug.cgi?id=74358
Eric Seidel <eric at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #184147|review?, commit-queue? |review+, commit-queue+
Flag| |
--- Comment #12 from Eric Seidel <eric at webkit.org> 2013-01-22 22:56:27 PST ---
(From update of attachment 184147)
View in context: https://bugs.webkit.org/attachment.cgi?id=184147&action=review
OK.
> Tools/Scripts/webkitpy/tool/steps/preparechangelog.py:31
> +import codecs
> import logging
> +import os
codecs and os imports are always "bad signs" that code is un-mockable. :)
> Tools/Scripts/webkitpy/tool/steps/preparechangelog.py:33
> import sys
So is sys! Clearly this file pre-dates our good FileSystem/Executive mocks.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list