[Webkit-unassigned] [Bug 74358] prepare-Changelog should support updating the list of changed files
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 22 22:14:12 PST 2013
https://bugs.webkit.org/show_bug.cgi?id=74358
Eric Seidel <eric at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #184122|review? |review+
Flag| |
--- Comment #9 from Eric Seidel <eric at webkit.org> 2013-01-22 22:16:04 PST ---
(From update of attachment 184122)
View in context: https://bugs.webkit.org/attachment.cgi?id=184122&action=review
This looks OK to me. There are some small mentions below.
> Tools/Scripts/webkitpy/tool/steps/preparechangelog.py:64
> + def _resolve_existing_entry(self, changelog_path):
This function is a bit long for my tastes. I'm not sure how I would break it up, possibly into _update_date_line and _update_description functions.
> Tools/Scripts/webkitpy/tool/steps/preparechangelog.py:65
> + """When this is called, the top entry in the ChangeLog has just been
It's better to assert instead of document via comment IMO.
> Tools/Scripts/webkitpy/tool/steps/preparechangelog.py:74
> + entries_gen = ChangeLog.parse_entries_from_file(changelog_file)
self. will make this easier to mock/override when we finally make this class ues Filesystem and thus be more testable.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list