[Webkit-unassigned] [Bug 107478] Add functions to ChangeLog - parse bug desc/changed functions, delete/prepend entries

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107478


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #184053|review?, commit-queue-      |review+, commit-queue+
               Flag|                            |




--- Comment #13 from Eric Seidel <eric at webkit.org>  2013-01-22 16:58:39 PST ---
(From update of attachment 184053)
View in context: https://bugs.webkit.org/attachment.cgi?id=184053&action=review

>>> Tools/Scripts/webkitpy/common/checkout/changelog.py:450
>>> +        codecs.open(self.path, "w", "utf-8").write(text + data)
>> 
>> Shouldn't we be using a FileSystem for this?  I'm sorry I didn't catch this before.  I guess ChangeLog doesn't correctly sit on top of our FileSystem abstraction anyway?
> 
> ChangeLog uses the fileinput module (i.e. the real filesystem) throughout, so I thought it would be a bit inconsistent to add functions which use the FileSystem abstraction. Probably using FileSystem would be better though, so I'll see if getting rid of fileinput isn't too messy.

I agree.  This doesn't make ChangeLog any worse than it already is (in terms of mockability).  We can make ChagneLog FileSystem-compatible later in another bug.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.