[Webkit-unassigned] [Bug 107171] shouldMoveCaretToHorizontalBoundaryWhenPastTopOrBottom should return false on Android

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107171





--- Comment #28 from Ryosuke Niwa <rniwa at webkit.org>  2013-01-22 15:44:58 PST ---
(In reply to comment #27)
> (From update of attachment 184048 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=184048&action=review
> 
> This is not
> 
> > Source/WebCore/editing/EditingBehavior.h:49
> > -    bool shouldMoveCaretToHorizontalBoundaryWhenPastTopOrBottom() const { return m_type != EditingWindowsBehavior; }
> > +    bool shouldMoveCaretToHorizontalBoundaryWhenPastTopOrBottom() const
> > +    {
> > +#if PLATFORM(CHROMIUM) && defined(ANDROID)
> > +        return false;
> > +#else
> > +        return m_type != EditingWindowsBehavior;
> > +#endif
> > +    }
> 
> This is not the way to fix this. It’s really bad to be putting #if statements in this header. The whole idea here was to define editing behavior types instead of having a pile of ifdefs. I am extremely unhappy to see shouldAllowSpellingSuggestionsWithoutSelection special cased for Chromium; too bad I was not able to stop this then when it first happened. The right way to do this is to add more editing behavior types, not add #if statements.

I don't think that makes sense in this particular case because this behavior is specific to Chromium port. Namely, I don't think we want to be adding EditingChromiumWindowsBehavior, EditingChromiumMacBehavior, EditingChromiumLinuxBehavior, and EditingChromiumAndroidBehavior in addition to ones we already have.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.