[Webkit-unassigned] [Bug 107171] shouldMoveCaretToHorizontalBoundaryWhenPastTopOrBottom should return false on Android
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 22 15:30:57 PST 2013
https://bugs.webkit.org/show_bug.cgi?id=107171
Darin Adler <darin at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #184048|review? |review-
Flag| |
--- Comment #27 from Darin Adler <darin at apple.com> 2013-01-22 15:32:48 PST ---
(From update of attachment 184048)
View in context: https://bugs.webkit.org/attachment.cgi?id=184048&action=review
This is not
> Source/WebCore/editing/EditingBehavior.h:49
> - bool shouldMoveCaretToHorizontalBoundaryWhenPastTopOrBottom() const { return m_type != EditingWindowsBehavior; }
> + bool shouldMoveCaretToHorizontalBoundaryWhenPastTopOrBottom() const
> + {
> +#if PLATFORM(CHROMIUM) && defined(ANDROID)
> + return false;
> +#else
> + return m_type != EditingWindowsBehavior;
> +#endif
> + }
This is not the way to fix this. It’s really bad to be putting #if statements in this header. The whole idea here was to define editing behavior types instead of having a pile of ifdefs. I am extremely unhappy to see shouldAllowSpellingSuggestionsWithoutSelection special cased for Chromium; too bad I was not able to stop this then when it first happened. The right way to do this is to add more editing behavior types, not add #if statements.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list