[Webkit-unassigned] [Bug 107171] shouldMoveCaretToHorizontalBoundaryWhenPastTopOrBottom should return false on Android

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107171





--- Comment #26 from Ryosuke Niwa <rniwa at webkit.org>  2013-01-22 15:19:20 PST ---
(In reply to comment #25)
> (From update of attachment 184048 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=184048&action=review
> 
> >> LayoutTests/editing/selection/test-if-should-move-caret-to-horizontal-boundary-forced-false-expected.txt:4
> >> +Caret location: [object Text] XX 0 true
> > 
> > I can't tell what "true" means here. In general, the test output should be self explanatory such that
> > someone who has never looked at the test should be able to tell what the test is testing and whether it's passing or failing and why.
> 
> Ok, how about just not outputting isCollapsed? This test doesn't actually care about it, and if it's ever false then there is certainly something more fundamental wrong with selection.

We do care about that because if isCollapsed is false, then we're getting a non-collapsed selection, which is clearly not intended.

> But, on that note, do you think I should label these other values (anchorNode, anchorNode.data, anchorOffset)?

Probably not.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.