[Webkit-unassigned] [Bug 106908] [GTK] Click on an anchor link makes page title dissappear

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=106908





--- Comment #3 from Manuel Rego Casasnovas <rego at igalia.com>  2013-01-22 13:36:53 PST ---
(In reply to comment #2)
> (From update of attachment 182779 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=182779&action=review
> 
> > Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp:856
> > -    priv->title = NULL;
> > +    priv->title = g_strdup(core(m_frame)->loader()->activeDocumentLoader()->title().string().utf8().data());
> 
> I'm not sure this is valid. The new title isn't necessarily available when a new load is committed. There's another FrameLoader messages that deals with titles. Perhaps what this is doing is resetting the title to the original value? it also makes sense to check the WebKit2 behavior.

I agree that the title could not be available at this point yet, but in these cases FrameLoaderClient::dispatchDidReceiveTitle will be called when it is available and the title will be updated accordingly.

The problem is in this particular case. When you click on an anchor, FrameLoaderClient::dispatchDidCommitLoad is called from FrameLoaderClient::dispatchDidNavigateWithinPage. Then FrameLoaderClient::dispatchDidCommitLoad resets title to NULL, however FrameLoaderClient::dispatchDidReceiveTitle is not called (as title is not received again).

About how it works in WK2, it's quite different as when you click on an anchor the method WebPageProxy::didSameDocumentNavigationForFrame is called. And it requests to update the URL but not the page title, moreover it doesn't reset the title property either.

Not sure about the best approach to fix the issue, any idea is welcomed :-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.