[Webkit-unassigned] [Bug 107444] Add error checking into OpenCL version of SVG filters.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107444


Stephen Chenney <schenney at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com,
                   |                            |simon.fraser at apple.com




--- Comment #2 from Stephen Chenney <schenney at chromium.org>  2013-01-22 07:37:22 PST ---
I am extremely unhappy about the sudden profusion of #ifdef OPENCL throughout the platform/graphics/filters/FilterEffect code.

The code required to manage OpenCLHandle, and the use of OpenCL as a backing for images, should all be placed in a platform specific version of ImageBuffer. That will get rid of almost all of the code cluttering FilterEffect, and is in fact the correct way to provide a platform specific back end.

Skia manages to provide hardware support for filters with only 2 methods inside a #if USE(SKIA). CG does it too. There is no obvious reason why you cannot do the same.

With specific regard to this patch, code to fallback to software from a hardware rendering would be useful for all platforms. This patch does not supply such a general approach.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.