[Webkit-unassigned] [Bug 107552] Web Inspector: Show element style panes in a tabbed pane when they are below the DOM tree pane.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 22 06:41:03 PST 2013
https://bugs.webkit.org/show_bug.cgi?id=107552
--- Comment #5 from Vladislav Kaznacheev <kaznacheev at chromium.org> 2013-01-22 06:42:55 PST ---
(From update of attachment 183977)
View in context: https://bugs.webkit.org/attachment.cgi?id=183977&action=review
>> Source/WebCore/inspector/front-end/ElementsPanel.js:194
>> + setTimeout(this._showSidebarPanes.bind(this), 0);
>
> Why setTimeout? Is this because of the tabbed pane's layout?
Creating TabbedPane does not work when called immediately because onResize is a notification and View.prototype._processWasShown does not set this._isShowing
>> Source/WebCore/inspector/front-end/ElementsPanel.js:202
>> + this._showTabbedSidebarPanes_();
>
> _showTabbedSidebarPanes_ - double privarte? :)
Done
>> Source/WebCore/inspector/front-end/ElementsPanel.js:205
>> + _showStackedSidebarPanes_: function ()
>
> extra space before ()
Done
>> Source/WebCore/inspector/front-end/ElementsPanel.js:207
>> + if (!this._tabbedPane && this.sidebarElement.firstChild)
>
> Why checking both?
When called for the first first time there is no tabbedPane. This will probably go away if I create a dedicated SidebarPaneStack class.
>> Source/WebCore/inspector/front-end/ElementsPanel.js:229
>> + _showTabbedSidebarPanes_: function () {
>
> { on the next line
Done
>> Source/WebCore/inspector/front-end/ElementsPanel.js:238
>> + pane.element.parentNode.removeChild(pane.element);
>
> pane.element.removeSelf();
Done
>> Source/WebCore/inspector/front-end/SidebarPane.js:136
>> + get lockExpanded()
>
> Please only use functions.
Done
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list