[Webkit-unassigned] [Bug 107406] Collapse PLATFORM(MAC)||PLATFORM(IOS) to just PLATFORM(MAC)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107406


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abarth at webkit.org




--- Comment #4 from Adam Barth <abarth at webkit.org>  2013-01-21 13:26:40 PST ---
> Other than that, I agree with your points.
> Maybe we could generalize OS(DARWIN) but I am afraid this will lead to many (OS(DARWIN) && !PLATFORM(QT)).
> 
> Maybe 
> - Replace "PLATFORM(MAC) || PLATFORM(IOS)" with "PLATFORM(IOS_MAC)".
>     PLATFORM(APPLE_DARWIN)?
>     PLATFORM(APPLE)

This is approach is most similar to the one we use for Chromium.  We use PLATFORM(CHROMIUM) for the general approach and then use OS-specific macros in the cases where the details vary based on the operating system.

You could also pick a more abstract name than PLATFORM(APPLE) if you might want to include Windows or other non-Apple operating systems in the future.  For example, PLATFORM(TITANIUM) refers to a nice metal.  :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.