[Webkit-unassigned] [Bug 102932] [EFL][WK2] Implement context menu in MiniBrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102932





--- Comment #2 from Christophe Dumez <christophe.dumez at intel.com>  2013-01-21 10:49:47 PST ---
(From update of attachment 183799)
View in context: https://bugs.webkit.org/attachment.cgi?id=183799&action=review

I think it would be nicer to split WK2 API changes from MiniBrowser changes.

> Source/WebKit2/UIProcess/API/efl/ewk_context_menu_item_private.h:66
> +    EwkContextMenu* parentMenu() const { return m_parentMenu; }

WebKit coding style: The getter should not be const if it returns a non-const pointer.

> Tools/MiniBrowser/efl/main.c:94
> +    Evas_Object *context_popup;

This should probably be initialized to NULL in window_create().

> Tools/MiniBrowser/efl/main.c:910
> +    Ewk_Context_Menu_Item *ewk_item =  (Ewk_Context_Menu_Item *)data;

extra space after =

> Tools/MiniBrowser/efl/main.c:1286
> +    ewk_settings_continuous_spell_checking_enabled_set(EINA_TRUE);

seems unrelated?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.