[Webkit-unassigned] [Bug 31155] [GStreamer] Implement setPreservesPitch()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31155





--- Comment #11 from Philippe Normand <pnormand at igalia.com>  2013-01-21 08:25:54 PST ---
(From update of attachment 183789)
View in context: https://bugs.webkit.org/attachment.cgi?id=183789&action=review

> Source/WebCore/ChangeLog:6
> +        It uses the gstreamer element scaletempo, and creates a new audio-sink

What is It? :) Maybe rephrase a bit a long the lines of "Enable audio pitch preservation by using the scaletempo GStreamer element when required by the MediaPlayer" or something similar

> Source/WebCore/ChangeLog:11
> +        No new tests (OOPS!).

The commit-queue will not like the OOPS here. Can you please instead a layout test shall be implemented at some point using WebAudio APIs as Eric suggested?

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1909
> +    // Construct audio sink if pitch preserving is enabled

Missing dot at EOL

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1913
> +    GError* error = 0;

Maybe use a GOwnPtr<GError> here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.