[Webkit-unassigned] [Bug 107131] [GTK] Implement testRunner::setTextDirection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107131





--- Comment #17 from Manuel Rego Casasnovas <rego at igalia.com>  2013-01-21 01:56:19 PST ---
(In reply to comment #16)
> (From update of attachment 183480 [details])
> I think it makes sense to wait on adding this until you make this change in WebKitWebViewBase.cpp as well.

I think you don't understand me before, the test is already passing in WK2.

It's included in the TestExpectations file of WK2 in the section "Tests working in WK2 and failing in WK1". So, this is already working in W2, and I'm just fixing the test in WK1.

With my patch the tests passes in both WK1 and WK2, so I've unflagged it in both TestExpectations files (in WK1 it was marked as "Failure" and in WK2 as "Pass").

You can see how it's implemented in WK2 in WebFrame::setTextDirection which is used from TestRunner::setTextDirection (Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.