[Webkit-unassigned] [Bug 105477] Implement ::cue() pseudo element property whitelist

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105477





--- Comment #15 from Dima Gorbik <dgorbik at apple.com>  2013-01-19 23:26:46 PST ---
(In reply to comment #14)
> (From update of attachment 183367 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=183367&action=review
> 
> > LayoutTests/media/track/track-css-property-whitelist.html:21
> > +            while (nextElementSibling.nodeType != 1) {
> 
> Nit: Node.ELEMENT_NODE would be clearer.
> 
> > LayoutTests/media/track/track-css-property-whitelist.html:23
> > +                nextElementSibling = nextElementSibling.nextSibling;
> > +            }
> 
> Nit: braces not needed.
> 
> > LayoutTests/media/track/track-css-property-whitelist.html:36
> > +            skipNonElements(cueNode);
> 
> Does this line do anything?
> 
> > Source/WebCore/css/RuleSet.cpp:111
> > +static inline PropertyWhitelistType determinePropertyWhitelistType(const AddRuleFlags addRuleFlags, const CSSSelector* selector)
> 
> This should have UNUSED_PARAM for platforms that don't ENABLE(VIDEO_TRACK)

Thanks, I will fix those when I touch the whitelisting code soon.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.