[Webkit-unassigned] [Bug 105477] Implement ::cue() pseudo element property whitelist
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jan 19 11:23:00 PST 2013
https://bugs.webkit.org/show_bug.cgi?id=105477
--- Comment #14 from Eric Carlson <eric.carlson at apple.com> 2013-01-19 11:24:48 PST ---
(From update of attachment 183367)
View in context: https://bugs.webkit.org/attachment.cgi?id=183367&action=review
> LayoutTests/media/track/track-css-property-whitelist.html:21
> + while (nextElementSibling.nodeType != 1) {
Nit: Node.ELEMENT_NODE would be clearer.
> LayoutTests/media/track/track-css-property-whitelist.html:23
> + nextElementSibling = nextElementSibling.nextSibling;
> + }
Nit: braces not needed.
> LayoutTests/media/track/track-css-property-whitelist.html:36
> + skipNonElements(cueNode);
Does this line do anything?
> Source/WebCore/css/RuleSet.cpp:111
> +static inline PropertyWhitelistType determinePropertyWhitelistType(const AddRuleFlags addRuleFlags, const CSSSelector* selector)
This should have UNUSED_PARAM for platforms that don't ENABLE(VIDEO_TRACK)
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list