[Webkit-unassigned] [Bug 107360] Remove unnecessary PLATFORM() tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 18 23:08:00 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=107360





--- Comment #4 from Laszlo Gombos <laszlo.gombos at webkit.org>  2013-01-18 23:09:49 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 183605 [details] [details])
> > Because PLATFORM(WIN) means AppleWin?
> 
> Yes, indeed.

These PLATFORM() macros are setup in Platform.h and from the definition it is clear that there are mutually exclusive.


#if defined(BUILDING_CHROMIUM__)
#define WTF_PLATFORM_CHROMIUM 1 
#elif defined(BUILDING_QT__)    
#define WTF_PLATFORM_QT 1       
#elif defined(BUILDING_WX__)    
#define WTF_PLATFORM_WX 1       
#elif defined(BUILDING_EFL__)   
#define WTF_PLATFORM_EFL 1      
#elif defined(BUILDING_GTK__)   
#define WTF_PLATFORM_GTK 1      
#elif defined(BUILDING_BLACKBERRY__)
#define WTF_PLATFORM_BLACKBERRY 1   
#elif OS(DARWIN)
#define WTF_PLATFORM_MAC 1
#elif OS(WINDOWS)
#define WTF_PLATFORM_WIN 1
#endif

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list