[Webkit-unassigned] [Bug 107207] Support selectively wrapping DOM accesses from certain V8 contexts.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jan 18 09:48:28 PST 2013
https://bugs.webkit.org/show_bug.cgi?id=107207
--- Comment #3 from WebKit Review Bot <webkit.review.bot at gmail.com> 2013-01-18 09:50:15 PST ---
Attachment 183488 did not pass style-queue:
Source/WebCore/bindings/v8/V8DOMCoverWrapping.h:44: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.h:45: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.h:47: Missing space inside { }. [whitespace/braces] [5]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.h:52: The parameter name "info" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.h:53: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.h:53: The parameter name "info" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.h:61: The parameter name "context" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.h:64: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.h:65: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.h:66: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.h:63: The parameter name "policy" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.h:67: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.h:70: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.h:69: The parameter name "policy" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.h:71: The parameter name "attribute" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.h:71: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMConfiguration.cpp:40: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMConfiguration.cpp:44: Use 0 instead of NULL. [readability/null] [5]
Source/WebCore/bindings/v8/V8DOMConfiguration.cpp:49: Use 0 instead of NULL. [readability/null] [5]
Source/WebCore/bindings/v8/V8DOMConfiguration.cpp:54: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMConfiguration.cpp:56: Use 0 instead of NULL. [readability/null] [5]
Source/WebCore/bindings/v8/V8DOMConfiguration.cpp:59: One line control clauses should not use braces. [whitespace/braces] [4]
Source/WebCore/bindings/v8/V8DOMConfiguration.cpp:67: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMConfiguration.cpp:74: One line control clauses should not use braces. [whitespace/braces] [4]
Source/WebCore/bindings/v8/V8DOMConfiguration.cpp:90: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMConfiguration.cpp:96: Use 0 instead of NULL. [readability/null] [5]
Source/WebCore/bindings/v8/V8DOMConfiguration.cpp:127: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8PerContextData.h:36: Alphabetical sorting problem. [build/include_order] [4]
Source/WebCore/bindings/v8/V8PerContextData.h:109: Use 0 instead of NULL. [readability/null] [5]
Source/WebCore/bindings/v8/V8PerContextData.h:109: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8PerContextData.h:127: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrappingPolicy.h:34: Alphabetical sorting problem. [build/include_order] [4]
Source/WebCore/bindings/v8/V8DOMCoverWrappingPolicy.h:43: This { should be at the end of the previous line [whitespace/braces] [4]
Source/WebCore/bindings/v8/V8DOMCoverWrappingPolicy.h:46: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrappingPolicy.h:45: The parameter name "policy" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/bindings/v8/V8DOMCoverWrappingPolicy.h:52: The parameter name "context" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/bindings/v8/V8DOMCoverWrappingPolicy.h:55: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrappingPolicy.h:54: The parameter name "policy" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/bindings/v8/V8DOMCoverWrappingPolicy.h:56: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.cpp:32: You should add a blank line after implementation file's own header. [build/include_order] [4]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.cpp:34: Alphabetical sorting problem. [build/include_order] [4]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.cpp:52: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.cpp:55: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.cpp:56: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.cpp:61: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.cpp:62: Use 0 instead of NULL. [readability/null] [5]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.cpp:63: Missing space inside { }. [whitespace/braces] [5]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.cpp:109: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.cpp:110: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.cpp:111: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.cpp:112: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.cpp:115: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.cpp:116: Use 0 instead of NULL. [readability/null] [5]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.cpp:116: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.cpp:117: Use 0 instead of NULL. [readability/null] [5]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.cpp:117: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.cpp:118: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.cpp:119: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.cpp:124: Use 0 instead of NULL. [readability/null] [5]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.cpp:132: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.cpp:133: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.cpp:137: Use 0 instead of NULL. [readability/null] [5]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.cpp:137: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.cpp:138: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.cpp:139: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.cpp:140: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.cpp:141: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.cpp:144: Use 0 instead of NULL. [readability/null] [5]
Source/WebCore/bindings/v8/V8DOMCoverWrapping.cpp:145: Use 0 instead of NULL. [readability/null] [5]
Source/WebKit/chromium/src/WebDOMCoverWrapping.cpp:31: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Source/Platform/chromium/public/WebDOMCoverWrapping.h:35: WEBKIT_EXPORT should not be used on a function with a body. [readability/webkit_export] [5]
Source/Platform/chromium/public/WebDOMCoverWrapping.h:36: WEBKIT_EXPORT should not be used on a function with a body. [readability/webkit_export] [5]
Source/Platform/chromium/public/WebDOMCoverWrapping.h:37: WEBKIT_EXPORT should not be used on a function with a body. [readability/webkit_export] [5]
Source/WebCore/bindings/v8/V8DOMCoverWrappingPolicy.cpp:32: You should add a blank line after implementation file's own header. [build/include_order] [4]
Source/WebCore/bindings/v8/V8DOMCoverWrappingPolicy.cpp:33: Found header this file implements after a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Source/WebCore/bindings/v8/V8DOMCoverWrappingPolicy.cpp:60: This { should be at the end of the previous line [whitespace/braces] [4]
Source/WebCore/bindings/v8/V8DOMCoverWrappingPolicy.cpp:62: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrappingPolicy.cpp:63: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrappingPolicy.cpp:64: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrappingPolicy.cpp:65: Missing space after , [whitespace/comma] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrappingPolicy.cpp:66: Missing space inside { }. [whitespace/braces] [5]
Source/WebCore/bindings/v8/V8DOMCoverWrappingPolicy.cpp:96: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrappingPolicy.cpp:102: Local variables should never be PassOwnPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5]
Source/WebCore/bindings/v8/V8DOMCoverWrappingPolicy.cpp:116: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrappingPolicy.cpp:117: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrappingPolicy.cpp:118: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/chromium/public/WebDOMCove..." exit_code: 1
Source/WebCore/bindings/v8/V8DOMCoverWrappingPolicy.cpp:119: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrappingPolicy.cpp:120: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrappingPolicy.cpp:121: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrappingPolicy.cpp:123: This { should be at the end of the previous line [whitespace/braces] [4]
Source/WebCore/bindings/v8/V8DOMCoverWrappingPolicy.cpp:130: Use 0 instead of NULL. [readability/null] [5]
Source/WebCore/bindings/v8/V8DOMCoverWrappingPolicy.cpp:138: Use 0 instead of NULL. [readability/null] [5]
Source/WebCore/bindings/v8/V8DOMCoverWrappingPolicy.cpp:142: Use 0 instead of NULL. [readability/null] [5]
Source/WebCore/bindings/v8/V8DOMCoverWrappingPolicy.cpp:147: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrappingPolicy.cpp:148: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrappingPolicy.cpp:156: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrappingPolicy.cpp:157: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrappingPolicy.cpp:158: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrappingPolicy.cpp:159: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMCoverWrappingPolicy.cpp:160: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMConfiguration.h:60: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMConfiguration.h:67: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMConfiguration.h:68: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMConfiguration.h:69: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMConfiguration.h:102: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
Source/WebCore/bindings/v8/V8DOMConfiguration.h:119: The parameter name "attribute" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/bindings/v8/V8DOMConfiguration.h:119: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
Total errors found: 107 in 17 files
If any of these errors are false positives, please file a bug against check-webkit-style.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list