[Webkit-unassigned] [Bug 104773] [EFL] Quit debug build without -DSHARED_CORE=ON

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104773





--- Comment #23 from Laszlo Gombos <laszlo.gombos at webkit.org>  2013-01-18 09:49:52 PST ---
(From update of attachment 182904)
View in context: https://bugs.webkit.org/attachment.cgi?id=182904&action=review

> CMakeLists.txt:144
>  include(Options${PORT})
>  
> +if (SHARED_CORE)
> +    set(JavaScriptCore_LIBRARY_TYPE SHARED)
> +    set(WebCore_LIBRARY_TYPE SHARED)
> +else ()
> +    set(JavaScriptCore_LIBRARY_TYPE STATIC)
> +    set(WebCore_LIBRARY_TYPE STATIC)
> +endif ()
> +
> +set(WebKit_LIBRARY_TYPE SHARED)
> +set(WebKit2_LIBRARY_TYPE SHARED)
> +set(WebCoreTestSupport_LIBRARY_TYPE STATIC)
> +

Is this change still needed ? Options${PORT} should have precedence over CMakeList.txt. This might have an impact on the WinCE port that has a "set(WebKit_LIBRARY_TYPE STATIC)" rule that needs to take precedence.

Sorry that I did not catch this in my previous review.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.