[Webkit-unassigned] [Bug 106792] Text Autosizing: don't autosize headers with multiple inline links.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=106792





--- Comment #17 from timvolodine at chromium.org  2013-01-18 09:43:58 PST ---
(From update of attachment 183479)
View in context: https://bugs.webkit.org/attachment.cgi?id=183479&action=review

>> Source/WebCore/rendering/TextAutosizer.cpp:310
>> +    //  1. it should not contain non-link text elements longer than 3 characters
> 
> it would be nice to know where these heuristics come from, like mention it in the changelog

done

>> Source/WebCore/rendering/TextAutosizer.cpp:312
>> +    //     have the same specified font size
> 
> 2. it should consist of min. 3 inline links using the same specified font size.

I guess this formulation could be confusing as it can be interpreted as: contain minimum 3 links of same font size, i.e. 3 links of size 16px and 1 of size 20px would still be ok.

>> Source/WebCore/rendering/TextAutosizer.cpp:335
>> +
> 
> This else needs braces according to style as it is spanning multiple actual code lines, not logical ones

done

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.