[Webkit-unassigned] [Bug 107131] [GTK] Implement testRunner::setTextDirection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107131





--- Comment #16 from Martin Robinson <mrobinson at webkit.org>  2013-01-18 09:37:46 PST ---
(From update of attachment 183480)
View in context: https://bugs.webkit.org/attachment.cgi?id=183480&action=review

> Tools/DumpRenderTree/gtk/TestRunnerGtk.cpp:954
> -    // FIXME: Implement.
> +    GOwnPtr<gchar> writingDirection(JSStringCopyUTF8CString(direction));
> +
> +    WebKitWebView* view = webkit_web_frame_get_web_view(mainFrame);
> +    ASSERT(view);
> +
> +    if (g_str_equal(writingDirection.get(), "auto"))
> +        gtk_widget_set_direction(GTK_WIDGET(view), GTK_TEXT_DIR_NONE);
> +    else if (g_str_equal(writingDirection.get(), "ltr"))
> +        gtk_widget_set_direction(GTK_WIDGET(view), GTK_TEXT_DIR_LTR);
> +    else if (g_str_equal(writingDirection.get(), "rtl"))
> +        gtk_widget_set_direction(GTK_WIDGET(view), GTK_TEXT_DIR_RTL);
> +    else
> +        fprintf(stderr, "TestRunner::setTextDirection called with unknown direction: '%s'.\n", writingDirection.get());
>  }

I think it makes sense to wait on adding this until you make this change in WebKitWebViewBase.cpp as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.