[Webkit-unassigned] [Bug 106792] Text Autosizing: don't autosize headers with multiple inline links.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=106792


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #183479|review?                     |review+
               Flag|                            |




--- Comment #16 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2013-01-18 09:20:28 PST ---
(From update of attachment 183479)
View in context: https://bugs.webkit.org/attachment.cgi?id=183479&action=review

> Source/WebCore/rendering/TextAutosizer.cpp:310
> +    //  1. it should not contain non-link text elements longer than 3 characters

it would be nice to know where these heuristics come from, like mention it in the changelog

> Source/WebCore/rendering/TextAutosizer.cpp:312
> +    //  2. it should contain at least 3 inline links, and all the links should
> +    //     have the same specified font size

2. it should consist of min. 3 inline links using the same specified font size.

> Source/WebCore/rendering/TextAutosizer.cpp:335
> +            else
> +                if (matchingFontSize != renderer->style()->specifiedFontSize())
> +                    return false;
> +

This else needs braces according to style as it is spanning multiple actual code lines, not logical ones

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.