[Webkit-unassigned] [Bug 107131] [GTK] Implement testRunner::setTextDirection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107131





--- Comment #10 from Martin Robinson <mrobinson at webkit.org>  2013-01-18 08:26:50 PST ---
(From update of attachment 183459)
View in context: https://bugs.webkit.org/attachment.cgi?id=183459&action=review

> Source/WebKit/gtk/webkit/webkitwebview.cpp:5367
> +void webkit_web_view_direction_changed(WebKitWebView* webView, GtkTextDirection, gpointer)

Okay. One nit here is that this function doesn't follow WebKit naming conventions (we started doing that always at some point). I can fix that and land this.

> LayoutTests/platform/gtk-wk2/TestExpectations:-507
>  Bug(GTK) fast/events/clear-edit-drag-state.html [ Pass ]
>  Bug(GTK) fast/events/dont-loose-last-event.html [ Pass ]
>  Bug(GTK) fast/events/drag-selects-image.html [ Pass ]
>  Bug(GTK) fast/forms/text-input-event.html [ Pass ]
> -Bug(GTK) fast/html/set-text-direction.html [ Pass ]

How is the WebKit2 test passing now? Source/WebKit/gtk/webkit/webkitwebview.cpp is only used for WebKit1.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.