[Webkit-unassigned] [Bug 107131] [GTK] Implement testRunner::setTextDirection
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jan 18 06:55:09 PST 2013
https://bugs.webkit.org/show_bug.cgi?id=107131
Philippe Normand <pnormand at igalia.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #183443|review? |review-
Flag| |
--- Comment #8 from Philippe Normand <pnormand at igalia.com> 2013-01-18 06:56:57 PST ---
(From update of attachment 183443)
View in context: https://bugs.webkit.org/attachment.cgi?id=183443&action=review
LGTM, just a couple of nitpicks!
> Source/WebKit/gtk/webkit/webkitwebview.cpp:272
> +static void webkit_web_view_direction_changed(WebKitWebView* webView, GtkTextDirection previousDirection, gpointer gpointer);
gpointer gpointer? I guess something like data would be better
> Source/WebKit/gtk/webkit/webkitwebview.cpp:5367
> +void webkit_web_view_direction_changed(WebKitWebView* webView, GtkTextDirection previousDirection, gpointer gpointer)
Well since the gpointer is not used you can omit to name it in the function signature.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list