[Webkit-unassigned] [Bug 107255] Add explicit keyword to constructors in platform-specific InspectorClient

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107255


Kentaro Hara <haraken at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #183424|review?                     |review+
               Flag|                            |




--- Comment #3 from Kentaro Hara <haraken at chromium.org>  2013-01-18 04:31:14 PST ---
(From update of attachment 183424)
View in context: https://bugs.webkit.org/attachment.cgi?id=183424&action=review

LGMT with nits.

>> Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.h:51
>> +        explicit InspectorClient(WebKitWebView* webView);
> 
> The parameter name "webView" adds no information, so it should be removed.  [readability/parameter_name] [5]

Nit: Remove it.

> Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h:62
> +    explicit WebInspectorClient(WebView *);

Nit: WebView * => WebView*

>> Source/WebKit/wince/WebCoreSupport/InspectorClientWinCE.h:37
>> +    explicit InspectorClientWinCE(WebView* webView);
> 
> The parameter name "webView" adds no information, so it should be removed.  [readability/parameter_name] [5]

Nit: Remove it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.