[Webkit-unassigned] [Bug 94987] Add systemTime to DOM events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=94987





--- Comment #96 from Robert Flack <flackr at chromium.org>  2013-01-17 21:34:30 PST ---
(In reply to comment #95)
> (From update of attachment 175826 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=175826&action=review
> 
> Honestly, I'm not super excited about this patch.  You're making these event constructors even more epic than they already are.  It seems odd that m_createTime and m_systemTime are intialized differently.  It's also unfortunate that we're going to end up with two timestamps for events.

It is odd, and unfortunate. I'm just not convinced there's a better way. For compatibility, we need the epoch based timeStamp property giving the creation time. The system time needs to be passed all the way up from the implementer's PlatformEvent time.

> Perhaps it would be better for someone else who is more excited about this feature to review this change?

Thanks for the suggestion. James, is this you?

> 
> > Source/WebCore/ChangeLog:10
> > +        http://lists.w3.org/Archives/Public/public-web-perf/2012Oct/0046.html and
> 
> Is there more of a spec that this email?  That email just says that he's interested and might include the feature in v2.

Not yet, to the best of my knowledge.

> 
> > Source/WebCore/dom/MouseEvent.cpp:197
> >      : MouseEvent(eventType, true, true, view, 0, 0, 0, 0, 0,
> >  #if ENABLE(POINTER_LOCK)
> > -                 0, 0,
> > +        0, 0,
> >  #endif
> > -                 false, false, false, false, 0, 0, 0, true)
> > +        false, false, false, false, 0, 0, 0, true, 0)
> 
> Epic initializers are epic.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.