[Webkit-unassigned] [Bug 107200] [WK2] Minimum layout width auto-sizing should use FrameView::enableAutoSizeMode so that it can shrink the viewport

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107200


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #183341|review?                     |review+
               Flag|                            |




--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com>  2013-01-17 18:30:04 PST ---
(From update of attachment 183341)
View in context: https://bugs.webkit.org/attachment.cgi?id=183341&action=review

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:3789
> +    m_minimumLayoutWidth = minimumLayoutWidth;
> +
> +    if (minimumLayoutWidth > 0)
> +        corePage()->mainFrame()->view()->enableAutoSizeMode(true, IntSize(minimumLayoutWidth, 1), IntSize(minimumLayoutWidth, INT_MAX));
> +    else
> +        corePage()->mainFrame()->view()->enableAutoSizeMode(false, IntSize(), IntSize());

Do we have to call enableAutoSizeMode() even when m_minimumLayoutWidth doesn't change?

> Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:-375
> -    if (m_minimumLayoutWidth > 0) {
> -        m_webPage->setSize(IntSize(m_minimumLayoutWidth, 0));
> -        m_webPage->layoutIfNeeded();
> +    if (!m_webPage->minimumLayoutWidth())
> +        m_webPage->setSize(size);
> +
> +    m_webPage->layoutIfNeeded();
>  
> +    if (m_webPage->minimumLayoutWidth()) {
>          contentSize = m_webPage->mainWebFrame()->contentBounds().size();
>          size = contentSize;
>      }
>  
> -    m_webPage->setSize(size);
> -    m_webPage->layoutIfNeeded();

This is pretty confusing. I don't know whose responsibility it is to set the size of the WebPage.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.