[Webkit-unassigned] [Bug 107171] Add Android-specific EditingBehavior

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107171





--- Comment #7 from Levi Weintraub <leviw at chromium.org>  2013-01-17 14:12:56 PST ---
(From update of attachment 183268)
View in context: https://bugs.webkit.org/attachment.cgi?id=183268&action=review

>> Source/WebCore/ChangeLog:11
>> +        of behavior for other platforms.
> 
> I don't think adding a new editing behavior makes sense here. r-.
> The only reason we decided to have these editing behaviors is so that we can test these behaviors in layout tests.
> Given that we're not doing it, ifdef will suffice.

I don't agree that encapsulating these classes of behavior in an enum makes less sense than adding ifdefs for them when the enum exists. I'd be happier covering this in layout tests than needing to disable/add specific expectations for Android, which would occur if just #ifdefing EditingUnixBehavior.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.