[Webkit-unassigned] [Bug 106979] [EFL][WK2] Implement runBeforeUnloadConfirmPanel on EFL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=106979





--- Comment #6 from Jaehun Lim <ljaehun.lim at samsung.com>  2013-01-16 16:19:39 PST ---
(In reply to comment #5)
> (From update of attachment 182935 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=182935&action=review
> 
> I am confused. You reorder the functions of PagreUIClient but it does not really match the order of WKPageUIClient (createNewPage for example).
> You ordered PageUIClientEfl.h (which is nice) but the implementaion of PageUIClientEfl::PageUIClientEfl keeps the old order.
> 
> Please make a separate patch to clean EFL PageUIClient, we land that first, and then we do the implementation for runBeforeUnloadConfirmPanel.
> 
> > Source/WebKit2/ChangeLog:11
> > +
> > +        Implement runBeforeUnloadConfirmPanel() to support window.onbeforeunload.
> > +        And adjsust the ordering of functions to kepp in sync with PageUIClient.
> > +
> > +        * UIProcess/efl/PageUIClientEfl.cpp:
> 
> Your patch now also sort the callbacks of PageUIClient correctly. You should have mentioned that in your ChangeLog.

Thank you for your review.
I uploaded another patch. Please see the https://bugs.webkit.org/show_bug.cgi?id=107060.
I'll upload new patch for runBeforeUnloadConfirmPanel after fixing style issues.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.