[Webkit-unassigned] [Bug 96272] Mistaken call to CRASH macro in NPN_InitializeVariantWithStringCopy

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96272





--- Comment #6 from Darin Adler <darin at apple.com>  2013-01-16 14:18:21 PST ---
(In reply to comment #5)
> I don't know if we can switch to fastMalloc/fastFree here.

I think we can.

> Perhaps it would be good to propose this switch in a separate new changeset ?

Perhaps, but maybe you misunderstand what Alexey meant.

Alexey’s point is that changing to fastMalloc/fastFree would be an alternate way to fix this very bug. Not that it would be an interesting bug unrelated change.

That fix would not require adding a special case for empty strings. Since we don’t have a good reason to optimize empty strings, it would be nice to fix this in a way that would not require making this otherwise-simple function more complex.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.