[Webkit-unassigned] [Bug 104773] [EFL] Quit debug build without -DSHARED_CORE=ON

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104773





--- Comment #22 from Halton Huo <halton.huo at gmail.com>  2013-01-15 19:12:39 PST ---
(In reply to comment #20)
> I was expecting this line to be placed in OptionsEfl.cmake. I think this approach can work as well but than you need to check and correct all the places where CMAKE_BUILD_TYPE is used already.
> 
> This would cause regression in the following places (and potentially some more):
> 
> OptionsCommon.cmake:if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU" AND "${LOWERCASE_CMAKE_HOST_SYSTEM_PROCESSOR}" MATCHES "(i[3-6]86|x86)" AND "${CMAKE_BUILD_TYPE}" STREQUAL "Debug")
> 
> OptionsEfl.cmake:if (CMAKE_BUILD_TYPE STREQUAL Release AND CMAKE_COMPILER_IS_GNUCC AND UNIX AND NOT APPLE)

Patch updated, I searched all the code base, you've find all places that ${CMAKE_BUILD_TYPE} is used, thanks for finding it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.