[Webkit-unassigned] [Bug 106963] Move TreeScope pointer to ContainerNode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=106963





--- Comment #6 from Elliott Sprehn <esprehn at chromium.org>  2013-01-15 17:50:38 PST ---
(From update of attachment 182882)
View in context: https://bugs.webkit.org/attachment.cgi?id=182882&action=review

I object to this change, it puts a branch into all the methods that go through the document pointer in the render tree (see RenderObject.h) which we know is a perf regression from the last time moritta tried replacing the document pointer. This also seems like a lot of complexity.

> Source/WebCore/dom/ContainerNode.h:278
> +    return toContainerNode(this)->treeScope();

This is going to be a perf regression since you're inserting a branch into all node->document() access which means a branch into lots of methods in the render tree.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.